Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create connector identity for org #2959

Merged
merged 3 commits into from
Aug 18, 2022
Merged

fix: create connector identity for org #2959

merged 3 commits into from
Aug 18, 2022

Conversation

BruceMacD
Copy link
Collaborator

Summary

When an org signs up they need a connector identity to start adding destinations. Create it by default.

Tests dependent on #2952

Checklist

  • Considered security implications of the change
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged

Related Issues

Resolves #2946

pdevine
pdevine approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@pdevine pdevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. The TestPaginationSelector test seems a little strange, but looks like it should work fine.

internal/cmd/users.go Show resolved Hide resolved
internal/server/data/data_test.go Outdated Show resolved Hide resolved
@BruceMacD BruceMacD merged commit c776af0 into main Aug 18, 2022
@BruceMacD BruceMacD deleted the brucemacd/org_connector branch August 18, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdevine pdevine pdevine approved these changes

@dnephin dnephin Awaiting requested review from dnephin

@jmorganca jmorganca Awaiting requested review from jmorganca

@kimskimchi kimskimchi Awaiting requested review from kimskimchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connector creation skipped in org signup
2 participants
@BruceMacD @pdevine