Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite email #2962

Merged
merged 9 commits into from
Aug 18, 2022
Merged

Invite email #2962

merged 9 commits into from
Aug 18, 2022

Conversation

ssoroka
Copy link
Contributor

@ssoroka ssoroka commented Aug 18, 2022

Summary

Checklist

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged
  • Considered data migrations for smooth upgrades

Related Issues

Resolves #

</p>
)}
</form>
<PasswordResetForm />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the component not in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed two files, ui/pages/accept-invite/index.js and ui/components/password-reset-form.js. added them now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the import is missing in this file

docker-compose.dev.yaml Show resolved Hide resolved
internal/server/config.go Show resolved Hide resolved
internal/server/data/migrations.go Show resolved Hide resolved
internal/server/passwordreset.go Show resolved Hide resolved
>
Set Password
</button>
{error && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use <ErrorMessage> component to display the error message - so the UI looks consistent throughout the app

Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back-end code looks good

@ssoroka ssoroka merged commit 2fad346 into main Aug 18, 2022
@ssoroka ssoroka deleted the invite-email branch August 18, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants