Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor a test function and remove a test helper #2977

Merged
merged 4 commits into from Aug 22, 2022
Merged

Refactor a test function and remove a test helper #2977

merged 4 commits into from Aug 22, 2022

Commits on Aug 18, 2022

  1. maintain: use a struct for test cases 

    Removing the need to cast the function.
    @dnephin
    dnephin committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    b8468c0 View commit details
    Browse the repository at this point in the history

  2. maintain: move prometheus metric to server field 

    We call this a lot in tests, and we can avoid passing in the registry each time by including it on
the struct.

The next commit will remove the argument from all the callers.
    @dnephin
    dnephin committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    5122f03 View commit details
    Browse the repository at this point in the history

  3. maintain: remove the registry arg 

    It now comes from a field on the method receiver.
    @dnephin
    dnephin committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    795ce7b View commit details
    Browse the repository at this point in the history

  4. maintain: remove InvalidateCache 

    The caches were removed in a previous commit.
    @dnephin
    dnephin committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    a1ff254 View commit details
    Browse the repository at this point in the history