Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: better analytics #3014

Merged
merged 1 commit into from
Aug 30, 2022
Merged

improve: better analytics #3014

merged 1 commit into from
Aug 30, 2022

Conversation

ssoroka
Copy link
Contributor

@ssoroka ssoroka commented Aug 23, 2022

Summary

Add analytics around org membership and signup

Checklist

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged
  • Considered data migrations for smooth upgrades

Related Issues

Resolves #

}
}
a.t.User(key.IssuedFor.String(), name)
a.t.OrgMembership(key.OrganizationID.String(), key.IssuedFor.String())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to combine these into one event where they are tracking similar things

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't exactly sure how this shows up in segment, but I was thinking they're separate things.

@ssoroka ssoroka merged commit 0f9a845 into main Aug 30, 2022
@ssoroka ssoroka deleted the analytics branch August 30, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants