Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove smtp testClient #3109

Merged
merged 1 commit into from Sep 2, 2022
Merged

fix: remove smtp testClient #3109

merged 1 commit into from Sep 2, 2022

Conversation

mxyng
Copy link
Collaborator

@mxyng mxyng commented Sep 2, 2022

Summary

Checklist

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged
  • Considered data migrations for smooth upgrades

Related Issues

Resolves #

@mxyng mxyng requested a review from ssoroka September 2, 2022 05:46
@ssoroka ssoroka marked this pull request as ready for review September 2, 2022 14:42
@ssoroka ssoroka merged commit bbb9a42 into main Sep 2, 2022
@ssoroka ssoroka deleted the mxyng/rm-smtp-test-client branch September 2, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssoroka ssoroka ssoroka approved these changes

@BruceMacD BruceMacD Awaiting requested review from BruceMacD

@dnephin dnephin Awaiting requested review from dnephin

@jmorganca jmorganca Awaiting requested review from jmorganca

@pdevine pdevine Awaiting requested review from pdevine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mxyng @ssoroka