fix: remove provider users for deleted identities #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
approved these changes
Oct 6, 2022
Comment on lines
749
to
751
| err := db.QueryRow(`SELECT identity_id FROM provider_users`).Scan(&remainingProviderUser) | ||
| assert.NilError(t, err) | ||
| assert.Equal(t, remainingProviderUser, uid.ID(2222)) |
There was a problem hiding this comment.
minor: I think this test could pass even when the first record is not deleted, if the DB decided to return the records in a different order than we expect. I'm not sure if that's possible.
Another option might be to SELECT count(*) from provider_users where identity_id = 1111 which should give us a count of 0.
BruceMacD
force-pushed
the
brucemacd/remove-provider-users-deleted-identity
branch
from
88692bf
to
ed32617
Compare
BruceMacD
deleted the
brucemacd/remove-provider-users-deleted-identity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should be merged after #3398
When an identity was deleted through the CLI the associated provider user was not deleted. This migration cleans up provider_user records that reference a deleted identity.
Checklist
Related Issues
Resolves #3397