Fix update destination #3604
Merged
Fix update destination #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start with the existing data so that we don't lose values for fields that are not updated. We have 3 non-updated fields now: CreatedAt, LastSeenAt, and Kind. Also remove the extra logic in the data layer, we no longer need this now that we're handling it properly in the API. This allows the update operation for destination to look like all the other update operations. Also add tests for the API endpoint.
dnephin
requested review from
ssoroka,
BruceMacD,
jmorganca and
pdevine
as code owners
BruceMacD
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Start with the existing data so that we don't lose values for fields that
are not updated. We have 3 non-update fields now: CreatedAt,
LastSeenAt, and Kind.
Also remove the extra logic in the data layer, we no longer need this
now that we're handling it properly in the API. This allows the
update operation for destination to look like all the other update
operations.
Also adds test cases for the
UpdateDestinationAPI endpoint.Related Issues
Resolves #3594