Add directory soft delete #52
Conversation
DirectoryID's returned from the API were being presented as a byte array rather than a uuid string. This corrects marshal and unmarshalling of DirectoryID's. Signed-off-by: Mike Mason <mimason@equinix.com>
Codecov Report
@@ Coverage Diff @@
## main #52 +/- ##
==========================================
- Coverage 94.16% 93.56% -0.60%
==========================================
Files 7 7
Lines 668 793 +125
==========================================
+ Hits 629 742 +113
- Misses 31 40 +9
- Partials 8 11 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Let's keep high test coverage |
mikemrm
force-pushed
the
add-soft-delete
branch
6 times, most recently
from
a983768
to
d4417f8
Compare
Implements soft deletions for directories. Deleting a parent directory also deletes all child directories. Signed-off-by: Mike Mason <mimason@equinix.com>
mikemrm
force-pushed
the
add-soft-delete
branch
from
d4417f8
to
b6d311e
Compare
There was a problem hiding this comment.
Very nice! Thanks for working on this!
Can you add the openapi specification for the delete call in https://github.com/infratographer/fertilesoil/blob/main/treeman-openapi-v1.yaml ? It's currently marked as a TODO.
Also, now that get/list of directories (and root ones) does not return deleted entries, can you create a GH issue about this? We should allow an admin to list deleted entries with a query parameter or something of the sort (we'd deny this functionality to normal users).
cc @pereztr5 can you review this as well?
Signed-off-by: Mike Mason <mimason@equinix.com>
|
I've updated the spec, and created #55 |
Implements soft deletions for directories.
Deleting a parent directory also deletes all child directories.
Closes #9