Skip to content
This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

add update directory #83

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

mikemrm
Copy link
Contributor

@mikemrm mikemrm commented Feb 24, 2023

This adds update directory support to all drivers, notifications, client and treemanager.

This resolves #50

app/v1/callback/callback.go Fixed Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #83 (40c43d6) into main (a7d38fd) will increase coverage by 0.26%.
The diff coverage is 96.87%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   94.06%   94.33%   +0.26%     
==========================================
  Files           7        7              
  Lines         910     1006      +96     
==========================================
+ Hits          856      949      +93     
- Misses         42       44       +2     
- Partials       12       13       +1     
Flag Coverage Δ
unittests 94.33% <96.87%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
storage/crdb/driver/driver.go 92.55% <85.00%> (-0.58%) ⬇️
internal/httpsrv/treemanager/treemanager.go 92.39% <100.00%> (+0.95%) ⬆️
tests/integration/common.go 99.25% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mikemrm mikemrm force-pushed the update-directories branch 3 times, most recently from d113e31 to e60c7a6 Compare February 24, 2023 18:33
Signed-off-by: Mike Mason <mimason@equinix.com>
@mikemrm mikemrm requested a review from JAORMX February 24, 2023 18:38
@mikemrm mikemrm marked this pull request as ready for review February 24, 2023 18:38
@mikemrm mikemrm requested a review from a team as a code owner February 24, 2023 18:38
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it 🚢

@mikemrm mikemrm merged commit ae0c631 into infratographer:main Feb 24, 2023
@mikemrm mikemrm deleted the update-directories branch February 24, 2023 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing directory update endpoint and logic
2 participants