Chart version should determine image tag for the chart #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This default had made the chart render out with the tag "latest" which isn't helpful with the pullPolicy of "IfNotPresent". Removing the tag in the values file lets the `.Chart.AppVersion` set the image tag instead. Signed-off-by: Adam Mohammed <admohammed@equinix.com>
fishnix
reviewed
Mar 24, 2023
JAORMX
approved these changes
Mar 24, 2023
| it's done in the pipeline through the tag. |
fishnix
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This default had made the chart render out with the tag "latest" which isn't helpful with the pullPolicy of "IfNotPresent". Removing the tag in the values file lets the
.Chart.AppVersionset the image tag instead.