Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate private key when using docker-up makefile target #5

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Dec 15, 2022

This auto-generates a private key in the tests/data directory allowing
for the docker-up makefile target to work out of the box and enable
easy testing.

Signed-off-by: Juan Antonio Osorio juan.osoriorobles@eu.equinix.com

This auto-generates a private key in the `tests/data` directory allowing
for the `docker-up` makefile target to work out of the box and enable
easy testing.

Signed-off-by: Juan Antonio Osorio <juan.osoriorobles@eu.equinix.com>
@JAORMX JAORMX requested review from a team and jnschaeffer December 15, 2022 10:16
Copy link
Contributor

@jnschaeffer jnschaeffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach works fine for me, but seems like the kind of feature we might want to document in the README.

Signed-off-by: Juan Antonio Osorio <juan.osoriorobles@eu.equinix.com>
@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 16, 2022

This approach works fine for me, but seems like the kind of feature we might want to document in the README.

done.

@jnschaeffer jnschaeffer merged commit 7c41389 into main Dec 16, 2022
@nicolerenee nicolerenee deleted the test-privkey branch April 13, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants