Use goose for database migrations #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a database migration tool is preferable over writing our own in-house database migration code. This commit adds goose to identity-api and uses it to run database migrations for the in-memory database store. Signed-off-by: John Schaeffer <jschaeffer@equinix.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,26 @@ | |||
| package storage | |||
Check warning
Code scanning / Revive (reported by Codacy)
should have a package comment
| @@ -0,0 +1,18 @@ | |||
| -- +goose Up | |||
| CREATE TABLE issuers ( | |||
Check warning
Code scanning / Tsqllint (reported by Codacy)
Expected table to use data compression
| mappings STRING | ||
| ); | ||
|
|
||
| CREATE TABLE user_info ( |
Check warning
Code scanning / Tsqllint (reported by Codacy)
Expected table to use data compression
| @@ -0,0 +1,18 @@ | |||
| -- +goose Up | |||
Check warning
Code scanning / Tsqllint (reported by Codacy)
Expected SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED near top of file
Signed-off-by: John Schaeffer <jschaeffer@equinix.com>
adammohammed
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a database migration tool is preferable over writing our own in-house database migration code. This PR adds goose to identity-api and uses it to run database migrations for the in-memory database store.