Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct type for blockEventBus #106

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Use correct type for blockEventBus #106

merged 1 commit into from
Jan 31, 2022

Conversation

vyzigold
Copy link
Contributor

This is needed to be able to use the blockEventBus. The operator complained for using incorrect type when trying to use "true" as a string.

@leifmadsen
Copy link
Member

I would suggest cherry picking this back to stable-1.4 as well.

@vyzigold vyzigold mentioned this pull request Jan 31, 2022
Closed
@leifmadsen leifmadsen merged commit 11f30de into master Jan 31, 2022
@leifmadsen leifmadsen deleted the jwysogla-blockEventBusType branch January 31, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leifmadsen leifmadsen leifmadsen approved these changes

@csibbitt csibbitt Awaiting requested review from csibbitt

Assignees

@vyzigold vyzigold

Labels
needs-backport
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vyzigold @leifmadsen