Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no implicit conversion of nil into String #99

Closed
doconnor-clintel opened this issue Dec 12, 2023 · 0 comments
Closed

no implicit conversion of nil into String #99

doconnor-clintel opened this issue Dec 12, 2023 · 0 comments

Comments

@doconnor-clintel
Copy link

doconnor-clintel commented Dec 12, 2023

Basically the same kind of issue as #90 and #91

The comment on that PR is:

As of 4.1.3 a DBF::NoColumnsDefined error will be raised when attempting to read records if no columns are defined

However, we see:

no implicit conversion of nil into String
/var/www/careright/shared/bundle/ruby/2.6.0/gems/dbf-4.2.4/lib/dbf/record.rb:11:in `initialize'
/var/www/careright/shared/bundle/ruby/2.6.0/gems/dbf-4.2.4/lib/dbf/record.rb:11:in `new'
/var/www/careright/shared/bundle/ruby/2.6.0/gems/dbf-4.2.4/lib/dbf/record.rb:11:in `initialize'
/var/www/careright/shared/bundle/ruby/2.6.0/gems/dbf-4.2.4/lib/dbf/table.rb:191:in `new'
/var/www/careright/shared/bundle/ruby/2.6.0/gems/dbf-4.2.4/lib/dbf/table.rb:191:in `record'
/var/www/careright/shared/bundle/ruby/2.6.0/gems/dbf-4.2.4/lib/dbf/table.rb:120:in `block in each'
/var/www/careright/shared/bundle/ruby/2.6.0/gems/dbf-4.2.4/lib/dbf/table.rb:120:in `times'
/var/www/careright/shared/bundle/ruby/2.6.0/gems/dbf-4.2.4/lib/dbf/table.rb:120:in `each'
/var/www/careright/releases/20231212045615/app/models/lookup.rb:506:in `import!'

Ideally, instantiating a record with data: nil would raise an argument error or similar, and reading a table + trying to instantiate a record wouldn't occur if it wasn't valid OR it raises a meaningful exception.

DBF Data:
Can't attach here unfortunately (licencing). I suspect we're managing to pass in nulls/invalid data/etc.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants