fix(overlays): only set inert for placementMode global

ing-bank · Dec 2, 2020 · 83359ac · 83359ac
1 parent 0f41bf2
commit 83359ac
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/cyan-onions-juggle.md b/.changeset/cyan-onions-juggle.md
@@ -0,0 +1,5 @@
+---
+'@lion/overlays': patch
+---
+
+Only set inert when placementMode is global, otherwise events are broken inside local overlay content
diff --git a/packages/overlays/src/OverlayController.js b/packages/overlays/src/OverlayController.js
@@ -1013,7 +1013,7 @@ export class OverlayController extends EventTargetShim {
     this._containFocusHandler = containFocus(this.contentNode);
     this.__hasActiveTrapsKeyboardFocus = true;
     if (this.manager) {
-      this.manager.informTrapsKeyboardFocusGotEnabled();
+      this.manager.informTrapsKeyboardFocusGotEnabled(this.placementMode);
     }
   }
 

diff --git a/packages/overlays/src/OverlaysManager.js b/packages/overlays/src/OverlaysManager.js
@@ -153,8 +153,11 @@ export class OverlaysManager {
     });
   }
 
-  informTrapsKeyboardFocusGotEnabled() {
-    if (this.siblingsInert === false) {
+  /**
+   * @param {'local' | 'global' | undefined} placementMode
+   */
+  informTrapsKeyboardFocusGotEnabled(placementMode) {
+    if (this.siblingsInert === false && placementMode === 'global') {
       if (OverlaysManager.__globalRootNode) {
         setSiblingsInert(this.globalRootNode);
       }