Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input-datepicker): disable invoker when readonly #105

Merged
merged 1 commit into from
Jun 24, 2019
Merged

fix(input-datepicker): disable invoker when readonly #105

merged 1 commit into from
Jun 24, 2019

Conversation

tlouisse
Copy link
Member

@tlouisse tlouisse commented Jun 18, 2019 •
edited
Loading

Fixes #92

@tlouisse tlouisse requested a review from bashmish June 18, 2019 16:10
@tlouisse tlouisse changed the title fix(input-datepicker): disable when invoker when readonly [wip] fix(input-datepicker): disable when invoker when readonly Jun 18, 2019
@tlouisse tlouisse changed the title [wip] fix(input-datepicker): disable when invoker when readonly [wip] fix(input-datepicker): disable invoker when readonly Jun 18, 2019
@tlouisse tlouisse force-pushed the fix/readonlyDatepicker branch 3 times, most recently from 143768a to 7d5f110 Compare June 20, 2019 12:01
@bashmish bashmish added the bug Something isn't working label Jun 20, 2019
@tlouisse tlouisse changed the title [wip] fix(input-datepicker): disable invoker when readonly fix(input-datepicker): disable invoker when readonly Jun 21, 2019
@tlouisse tlouisse force-pushed the fix/readonlyDatepicker branch 2 times, most recently from c23cc26 to a2b3d70 Compare June 21, 2019 12:00
bashmish
bashmish reviewed Jun 21, 2019
View reviewed changes
Copy link
Contributor

@bashmish bashmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me now, let's just finalize last small bits on Monday 👍

@bashmish bashmish mentioned this pull request Jun 24, 2019
Closed
@bashmish bashmish merged commit adef259 into master Jun 24, 2019
@daKmoR daKmoR deleted the fix/readonlyDatepicker branch June 24, 2019 22:24
fcarrascosa pushed a commit to fcarrascosa/lion that referenced this pull request Nov 28, 2019
Merge pull request ing-bank#105 from ing-bank/fix/readonlyDatepicker
2a5ad20 
fix(input-datepicker): disable invoker when readonly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashmish bashmish bashmish approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[input-datepicker] Readonly property not working properly
2 participants
@tlouisse @bashmish