-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: allow running tests in IE11 on BrowserStack #120
Conversation
I don't mind merging this as as since it has some value: you are allowed to run tests in IE11 on browserstack, but it does not close the issue #108, the problem is broader there, including the fact that we need to fix flaky tests as well. Also |
- @lion/button@0.1.25 - @lion/calendar@0.1.21 - @lion/checkbox-group@0.1.23 - @lion/checkbox@0.1.21 - @lion/choice-input@0.1.21 - @lion/field@0.1.21 - @lion/fieldset@0.1.21 - @lion/form-system@0.0.24 - @lion/form@0.1.23 - @lion/input-amount@0.1.21 - @lion/input-date@0.1.21 - @lion/input-datepicker@0.1.18 - @lion/input-email@0.1.21 - @lion/input-iban@0.1.22 - @lion/input@0.1.21 - @lion/overlays@0.2.6 - @lion/popup@0.1.25 - @lion/radio-group@0.1.23 - @lion/radio@0.1.21 - @lion/select@0.1.21 - @lion/textarea@0.1.21 - @lion/tooltip@0.1.25 - @lion/validate@0.2.9
…into runTestAllBrowsersBS
…into runTestAllBrowsersBS
I've realised that I was wrong.
The reason it needs to be like this is because often the code is transpiled and run in production on every browser, while some people might have differential builds and serve different code based on browser agent sniffing. So basically transpiled code needs to work everywhere. So I'm closing this MR. if you want to run tests for yourself, please use this terminal command: yarn test:bs --legacy --browsers=bs_win10_ie_11 or more precisely - with BROWSER_STACK_USERNAME=%name% BROWSER_STACK_ACCESS_KEY=%key% yarn test:bs --legacy --browsers=bs_win10_ie_11 |
I have create a new npm script to run all tests in ie11 browser - browserstack