Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing notebooks + fixes #67

Merged
merged 6 commits into from Nov 11, 2020
Merged

Testing notebooks + fixes #67

merged 6 commits into from Nov 11, 2020

Conversation

sbrugman
Copy link
Collaborator

Testing: Change notebook testing to pytest-notebook (current tests were skipped). Add try-except ImportError for pyspark code.

Bugfix in hist.py that broke the advanced tutorial.

Enhancement: Add %%capture to pip install inside of notebooks.

Enhancement: Make package install in notebooks work with paths with spaces.

sbrugman and others added 3 commits October 29, 2020 16:38
…re skipped). Add try-except ImportError for pyspark code.

Bugfix in hist.py that broke the advanced tutorial.

Enhancement: Add %%capture to pip install inside of notebooks.

Enhancement: Make package install in notebooks work with paths with spaces.
@tomcis tomcis changed the title Testing notebooks + fixes [WIP] Testing notebooks + fixes Nov 10, 2020
…anyway). Changed the notebook to fix the issue, left the code for reference.
@sbrugman sbrugman changed the title [WIP] Testing notebooks + fixes Testing notebooks + fixes Nov 10, 2020
@sbrugman sbrugman requested a review from tomcis November 11, 2020 00:01
@tomcis tomcis merged commit 703f680 into develop Nov 11, 2020
@tomcis tomcis deleted the feature/notebook-tests branch November 11, 2020 22:37
sbrugman added a commit that referenced this pull request Dec 7, 2020
* Testing: Change notebook testing to pytest-notebook (current tests were skipped). Add try-except ImportError for pyspark code.

Bugfix in hist.py that broke the advanced tutorial.

Enhancement: Add %%capture to pip install inside of notebooks.

Enhancement: Make package install in notebooks work with paths with spaces.

* Update requirements-test.txt

* Update test_notebooks.py

* Pickle doesn't work with tests (not really a popmon-specific feature anyway). Changed the notebook to fix the issue, left the code for reference.

* Increase timeout
sbrugman added a commit that referenced this pull request Dec 7, 2020
* Testing: Change notebook testing to pytest-notebook (current tests were skipped). Add try-except ImportError for pyspark code.

Bugfix in hist.py that broke the advanced tutorial.

Enhancement: Add %%capture to pip install inside of notebooks.

Enhancement: Make package install in notebooks work with paths with spaces.

* Update requirements-test.txt

* Update test_notebooks.py

* Pickle doesn't work with tests (not really a popmon-specific feature anyway). Changed the notebook to fix the issue, left the code for reference.

* Increase timeout
sbrugman added a commit that referenced this pull request Dec 7, 2020
v0.3.11 release

Features:
* Traffic light overview (#62)

Documentation:
* Downloads badge readme
* List talks and articles in readme (#66)
* Add image to README.rst (#64)

Other improvements:
* Change notebook testing to pytest-notebook (previously these tests were skipped in CI). Add try-except ImportError for pyspark code. (#67)
* Fix a few typo's
* suppress "matplotlib backend" verbose warning
* click on "popmon report" also scrolls to top
* Update HTML reports using Github Actions (#63)
* Bugfix in hist.py that broke the advanced tutorial.

Notebooks:
* Add %%capture to pip install inside of notebooks.
* Make package install in notebooks work with paths with spaces.
* Pickle doesn't work with tests (not really a popmon-specific feature anyway). Changed the notebook to fix the issue, left the code for reference.

* Version bump
mbaak pushed a commit that referenced this pull request Jan 18, 2021
v0.3.11 release

Features:
* Traffic light overview (#62)

Documentation:
* Downloads badge readme
* List talks and articles in readme (#66)
* Add image to README.rst (#64)

Other improvements:
* Change notebook testing to pytest-notebook (previously these tests were skipped in CI). Add try-except ImportError for pyspark code. (#67)
* Fix a few typo's
* suppress "matplotlib backend" verbose warning
* click on "popmon report" also scrolls to top
* Update HTML reports using Github Actions (#63)
* Bugfix in hist.py that broke the advanced tutorial.

Notebooks:
* Add %%capture to pip install inside of notebooks.
* Make package install in notebooks work with paths with spaces.
* Pickle doesn't work with tests (not really a popmon-specific feature anyway). Changed the notebook to fix the issue, left the code for reference.

* Version bump
tomcis added a commit that referenced this pull request Mar 15, 2021
* v0.3.11 release (#74)

v0.3.11 release

Features:
* Traffic light overview (#62)

Documentation:
* Downloads badge readme
* List talks and articles in readme (#66)
* Add image to README.rst (#64)

Other improvements:
* Change notebook testing to pytest-notebook (previously these tests were skipped in CI). Add try-except ImportError for pyspark code. (#67)
* Fix a few typo's
* suppress "matplotlib backend" verbose warning
* click on "popmon report" also scrolls to top
* Update HTML reports using Github Actions (#63)
* Bugfix in hist.py that broke the advanced tutorial.

Notebooks:
* Add %%capture to pip install inside of notebooks.
* Make package install in notebooks work with paths with spaces.
* Pickle doesn't work with tests (not really a popmon-specific feature anyway). Changed the notebook to fix the issue, left the code for reference.

* Version bump

* Release/0.3.14 (#92)

* Pin histogram version

* Docs update (#96)

* Initialize spark with both histogrammar jar files

Co-authored-by: Max Baak <maxbaak@gmail.com>

* [pre-commit.ci] pre-commit autoupdate

Co-authored-by: Simon Brugman <sbrugman@users.noreply.github.com>
Co-authored-by: Tomas Sostak <shostakas@gmail.com>
Co-authored-by: Max Baak <maxbaak@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
mbaak pushed a commit that referenced this pull request Mar 23, 2021
v0.3.11 release

Features:
* Traffic light overview (#62)

Documentation:
* Downloads badge readme
* List talks and articles in readme (#66)
* Add image to README.rst (#64)

Other improvements:
* Change notebook testing to pytest-notebook (previously these tests were skipped in CI). Add try-except ImportError for pyspark code. (#67)
* Fix a few typo's
* suppress "matplotlib backend" verbose warning
* click on "popmon report" also scrolls to top
* Update HTML reports using Github Actions (#63)
* Bugfix in hist.py that broke the advanced tutorial.

Notebooks:
* Add %%capture to pip install inside of notebooks.
* Make package install in notebooks work with paths with spaces.
* Pickle doesn't work with tests (not really a popmon-specific feature anyway). Changed the notebook to fix the issue, left the code for reference.

* Version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants