Multi class shap rfecv #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multi-class classifiers and regressors are now compatible, so we remove references to binary classification
Matgrb
suggested changes
Dec 3, 2021
|
Also please have a look what has changed in, just to make sure your PR is aligned #175 |
Matgrb
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Looks good, thanks for the work and sorry for the delay.
If you fix the conflicts and make the test sucessfully run we can directly merge ;) Keep in mind that there are 3 new functions added for EarlyStoppingRFECV that pass early stopping parameters differently based on model type: LGBM/XGB/CatBoost
|
Hi @Matgrb, can we merge this? |
|
Hi @lproth , sorry for the delayed response and thank you for your contribution, could you update this branch to be compatible with the latest changes on the main? |
|
This can only be merged when some unit tests are added. |
ReinierKoops
previously approved these changes
Dec 5, 2023
ReinierKoops
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re #169 I have added support for multi-class classification and ensured that regression will still work. I haven't written any unit tests because I'm not familiar with how pytest works, but all that should be needed is to re-run the existing tests with a multi-class target instead of binary.