Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to Pandas implementation to keep the order #197

Merged
merged 8 commits into from
Jun 2, 2023
Merged

Change to Pandas implementation to keep the order #197

merged 8 commits into from
Jun 2, 2023

Conversation

ReinierKoops
Copy link
Contributor

Merging this will preserve the order of the features as suggested by @PaulZhutovsky .

@ReinierKoops
Copy link
Contributor Author

#196 , this is an improvement on the previous implementation improvement.

@ReinierKoops ReinierKoops mentioned this pull request Jun 1, 2023
Closed
gverbock
gverbock reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@gverbock gverbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ReinierKoops I made some small comments on the PR

tests/feature_elimination/test_feature_elimination.py Outdated Show resolved Hide resolved
probatus/feature_elimination/feature_elimination.py Show resolved Hide resolved
tests/feature_elimination/test_feature_elimination.py Outdated Show resolved Hide resolved
@gverbock gverbock merged commit 5645d2e into ing-bank:main Jun 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gverbock gverbock gverbock left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ReinierKoops @gverbock