Fixing tests for shap==0.42.1 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ReinierKoops Could you have a look at this PR? |
|
Lets see how it runs. Please have a look at the file https://github.com/ing-bank/probatus/blob/main/CONTRIBUTING.md |
|
Thanks again, nice work! |
|
@ReinierKoops I am glad to help :) I followed the instructions, however I am not sure whether I should use pre-commit within venv or globally. Do yo personally use venv or poetry or something else? |
|
Personally I use conda separate env to test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#225
Also fixed one test for numpy>=1.24.0.
Btw, what is the suggested workflow with pre-commit? Add it into virtual env and commit from a command line after I used pre-commit run? Do you use vscode as well?