Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and reenable notebook tests #235

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Fix and reenable notebook tests #235

merged 6 commits into from
Oct 23, 2023

Conversation

adri0
Copy link
Collaborator

@adri0 adri0 commented Oct 19, 2023

  • Refactor notebook tests to run all ipynb found in the docs folder.
  • Allows for exclusion of currently breaking notebooks.
  • Notebook tests will only run if the env variable TEST_NOTEBOOKS is set (which by default is not set).
  • Reenable notebooks tests in Github test workflow (by setting TEST_NOTEBOOKS=1).
  • Set a timeout (180 seconds) to which notebooks need to run.
  • Refactor the notebook docs/tutorials/nb_automatic_best_num_features.ipynb to run faster.
  • Fix compatibility issue on notebook docs/tutorials/nb_imputation_comparison.ipynb related to IterativeImputer.
  • Fix breaking SHAP dependency.

@adri0 adri0 linked an issue Oct 19, 2023 that may be closed by this pull request
@adri0 adri0 changed the title [WIP] Refactor notebook tests [WIP] Fix and reenable notebook tests Oct 19, 2023
@adri0
Copy link
Collaborator Author

adri0 commented Oct 19, 2023

Note to self: once this is merged create the following issues:

  • Fix still failing notebooks.
  • Reconsider enabling lightgbm tests?

@adri0 adri0 marked this pull request as ready for review October 19, 2023 16:01
@adri0 adri0 changed the title [WIP] Fix and reenable notebook tests Fix and reenable notebook tests Oct 19, 2023
@adri0 adri0 merged commit 98e3329 into main Oct 23, 2023
12 checks passed
@adri0 adri0 deleted the fix-notebook-tests branch October 23, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing notebooks: missing tests; problems testing with LGBM
2 participants