Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify probatus: remove 'old' code, update mkdocs config #237

Merged
merged 14 commits into from
Mar 17, 2024

Conversation

ReinierKoops
Copy link
Contributor

Remove a lot of the extra packages which makes maintaining MKDOCS easier.

@ReinierKoops
Copy link
Contributor Author

Also enables a more modular approach to installing packages.

@ReinierKoops
Copy link
Contributor Author

Possible fix for #227

@ReinierKoops
Copy link
Contributor Author

ReinierKoops commented Mar 14, 2024

PR #238 depends on this PR, since this should also solve the issues blocking that PR.

@ReinierKoops ReinierKoops changed the title simplify mkdocs config simplify probatus: remove 'old' code, update mkdocs config Mar 14, 2024
@ReinierKoops
Copy link
Contributor Author

ReinierKoops commented Mar 14, 2024

This PR should simplify Probatus by deprecating code that hasn't been updated in a long time and simplify some of its dependencies.

  • bucketing is better done in Feature Engine, Skorecard or Sklearn, etc
  • statistical tests and sampling are better done in Statsmodels, scipy, etc
  • imputation is better done in Feature Engine, etc

Due to the breaking changes (removing (never used) functionality (as found by asking multiple users) to make maintainability easier for this repository and start introducing new functionality) the version numbering starts from 3.0.0.

@ReinierKoops ReinierKoops requested a review from adri0 March 17, 2024 14:31
@adri0
Copy link
Collaborator

adri0 commented Mar 17, 2024

Wow major refactoring going on! :)

.pre-commit-config.yaml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
docs/img/autodist.png Outdated Show resolved Hide resolved
@ReinierKoops ReinierKoops merged commit cbd0d34 into main Mar 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants