Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix selection of best categories bucketers.py #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skorecard/bucketers/bucketers.py
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ def _get_feature_splits(self, feature, X, y, X_unfiltered=None):
normalized_counts = X_y[feature].value_counts(normalize=True)

# Limit number of categories if set.
normalized_counts = normalized_counts[: self.max_n_categories]
normalized_counts = normalized_counts[-self.max_n_categories:]
# Remove less frequent categories
normalized_counts = normalized_counts[normalized_counts >= self.tol]

Expand Down
Loading