CHG: [C++] maintain min-heap property between calls

Suggest change by Tomasz W.
ing-bank · Feb 1, 2024 · 9075ff5 · 9075ff5
1 parent abf0192
commit 9075ff5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/sparse_dot_topn_core/include/sparse_dot_topn/maxheap.hpp b/src/sparse_dot_topn_core/include/sparse_dot_topn/maxheap.hpp
@@ -86,13 +86,13 @@ class MaxHeap {
      * \param val value to store
      */
     eT push_pop(const idxT idx, const eT val) {
+        std::pop_heap(heap.begin(), heap.end(), compare());
         heap.back().order = n_set;
         heap.back().idx = idx;
         heap.back().val = val;
         n_set++;
         std::push_heap(heap.begin(), heap.end(), compare());
-        std::pop_heap(heap.begin(), heap.end(), compare());
-        return heap.back().val;
+        return heap.front().val;
     }
 
     /**