Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: fix cython to 0.29.36 #85

Merged
merged 1 commit into from Jul 24, 2023
Merged

Conversation

kykyi
Copy link
Contributor

@kykyi kykyi commented Jul 21, 2023

In relation to issue #84

Cython recently had a major release which is causing havoc amongst dependencies near and far.

This PR fixes cython 0.29.36 to prevent pip install from trying and failing to pull cython 3.

@kykyi kykyi marked this pull request as draft July 21, 2023 10:03
@kykyi kykyi marked this pull request as ready for review July 21, 2023 10:57
@kykyi
Copy link
Contributor Author

kykyi commented Jul 21, 2023

Can confirm I am using this in my local environment with poetry:

sparse-dot-topn =  { git = "https://github.com/kykyi/sparse_dot_topn" }

And it is building!

johnnymercado
johnnymercado previously approved these changes Jul 24, 2023
rafita96
rafita96 previously approved these changes Jul 24, 2023
@RUrlus RUrlus dismissed stale reviews from johnnymercado and rafita96 July 24, 2023 18:45

No involvement with project

Hard-code the requirement to the most recent minor release

Pin cython in build-system.requires
@RUrlus
Copy link
Collaborator

RUrlus commented Jul 24, 2023

@kykyi thanks for the PR. I squashed the commits and opened the requirements slightly. Will merge when the tests pass.

@RUrlus RUrlus self-requested a review July 24, 2023 19:06
@RUrlus RUrlus self-assigned this Jul 24, 2023
@RUrlus RUrlus merged commit 121355a into ing-bank:master Jul 24, 2023
10 checks passed
@kykyi
Copy link
Contributor Author

kykyi commented Jul 25, 2023

@RUrlus thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants