[MIG] account_interests: Migration to 17.0

closes #482 Signed-off-by: Juan José Scarafía <jjs@adhoc.com.ar>
ingadhoc · May 13, 2024 · 591bdc8 · 591bdc8
1 parent 47da27b
commit 591bdc8
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 16 deletions.
diff --git a/account_interests/__manifest__.py b/account_interests/__manifest__.py
@@ -19,7 +19,7 @@
 ##############################################################################
 {
     'name': 'Interests Management',
-    'version': "16.0.1.1.0",
+    'version': "17.0.1.1.0",
     'category': 'Accounting',
     'sequence': 14,
     'summary': 'Calculate interests for selected partners',
@@ -34,6 +34,6 @@
         'data/ir_cron_data.xml',
         'security/ir.model.access.csv',
     ],
-    'installable': False,
+    'installable': True,
     'application': False,
 }
diff --git a/account_interests/models/res_company_interest.py b/account_interests/models/res_company_interest.py
@@ -143,22 +143,18 @@ def create_invoices(self, to_date, groupby='partner_id'):
             ('company_id', '=', self.company_id.id)], limit=1)
 
         move_line_domain = self._get_move_line_domains(to_date)
-
         # Check if a filter is set
         if self.domain:
             move_line_domain += safe_eval(self.domain)
 
-        fields = ['id', 'amount_residual', 'partner_id', 'account_id']
-        if groupby not in fields:
-            fields += [groupby]
+        fields = ['id:recordset', 'amount_residual:sum', 'partner_id:recordset', 'account_id:recordset']
 
         move_line = self.env['account.move.line']
-        grouped_lines = move_line.read_group(
+        grouped_lines = move_line._read_group(
             domain=move_line_domain,
-            fields=fields,
             groupby=[groupby],
+            aggregates=fields,
         )
-
         self = self.with_context(
             company_id=self.company_id.id,
             mail_notrack=True,
@@ -167,8 +163,7 @@ def create_invoices(self, to_date, groupby='partner_id'):
         total_items = len(grouped_lines)
         _logger.info('%s interest invoices will be generated', total_items)
         for idx, line in enumerate(grouped_lines):
-
-            debt = line['amount_residual']
+            debt = line[2]
 
             if not debt or debt <= 0.0:
                 _logger.info("Debt is negative, skipping...")
@@ -177,12 +172,10 @@ def create_invoices(self, to_date, groupby='partner_id'):
             _logger.info(
                 'Creating Interest Invoice (%s of %s) with values:\n%s',
                 idx + 1, total_items, line)
-            partner_id = line[groupby][0]
-
+            partner_id = line[0].id
             partner = self.env['res.partner'].browse(partner_id)
             move_vals = self._prepare_interest_invoice(
                 partner, debt, to_date, journal)
-
             move = self.env['account.move'].create(move_vals)
 
             if self.automatic_validation:

diff --git a/account_interests/security/ir.model.access.csv b/account_interests/security/ir.model.access.csv
@@ -1,3 +1,3 @@
 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
-access_res_company_interest_all,access_res_company_interest_all,model_res_company_interest,,1,0,0,0
+access_res_company_interest_all,access_res_company_interest_all,model_res_company_interest,base.group_user,1,0,0,0
 access_res_company_interest_manager,access_res_company_interest_manager,model_res_company_interest,account.group_account_manager,1,1,1,1
diff --git a/account_interests/views/res_company_views.xml b/account_interests/views/res_company_views.xml
@@ -11,7 +11,7 @@
                     <separator string="Intereses Automáticos"/>
                     <field name="interest_ids" context="{'default_company_id': id}">
                         <tree>
-                            <field name="company_id" invisible="1" required="0"/>
+                            <field name="company_id" required="0" invisible="1"/>
                             <field name="receivable_account_ids" widget="many2many_tags"/>
                             <field name="interest_product_id"/>
                             <field name="analytic_account_id" groups="analytic.group_analytic_accounting"/>