Skip to content

Commit

Permalink
[REM] _payment_group: constraint that blocks pay to company
Browse files Browse the repository at this point in the history
Esta restriccion, tal como figuraba en sus comentarios, ya no es necesaria

closes #311

Signed-off-by: Juan José Scarafía <jjs@adhoc.com.ar>
  • Loading branch information
jjscarafia committed Nov 8, 2022
1 parent 03b78e9 commit 4c53b58
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions account_payment_group/models/account_payment_group.py
Expand Up @@ -511,16 +511,6 @@ def check_to_pay_lines(self):
raise ValidationError(_('Payment group for partner %s but payment lines are of partner %s') % (
rec.partner_id.name, to_pay_partners.name))

@api.constrains('partner_id', 'company_id')
def _check_no_transfer(self):
# TODO en realidad si habría casos de uso donde esto es necesario se podría permitir sin problemas,
# de hecho odoo hizo un cambio para permitirlo acá
# https://github.com/odoo/odoo/commit/362d8cbf7724431672b8b73fb5f4682d4d2c3f66
# igual por el momento parece ser más apropiado recomendar transferencia interna
transfers = self.filtered(lambda x: x.company_id.partner_id == x.partner_id)
if transfers:
raise ValidationError(_("You can't make a payment/receipt to your same company, create an internal transfer instead"))

# from old account_payment_document_number

@api.depends('name')
Expand Down

0 comments on commit 4c53b58

Please sign in to comment.