[FIX] account_withholding: compute tax_repartition_line_id when accou…

…nt payment group is posted

Ticket: 62171

account_withholding/__manifest__.py

@@ -34,5 +34,5 @@
     'installable': True,
     'name': 'Withholdings on Payments',
     'test': [],
-    'version': "16.0.1.1.0",
+    'version': "16.0.1.2.0",
 }

account_withholding/migrations/16.0.1.2.0/post-migration.py

@@ -0,0 +1,15 @@
+from openupgradelib import openupgrade
+import logging
+logger = logging.getLogger(__name__)
+
+
+@openupgrade.migrate()
+def migrate(env, version):
+    withholdings = env['account.payment'].search([]).filtered(lambda x: x.tax_withholding_id and x.state == 'posted')
+    for withholding in withholdings:
+        liquidity_lines, counterpart_lines, writeoff_lines = withholding._seek_for_lines()
+        if not liquidity_lines.tax_repartition_line_id or not liquidity_lines.tax_line_id:
+            rep_line = withholding._get_withholding_repartition_line()
+            liquidity_lines.tax_repartition_line_id = rep_line
+            liquidity_lines.tax_line_id = rep_line.tax_id
+    logger.info('Se computaron campos tax_repartition_line_id y tax_line_id en líneas de retenciones ya publicadas')

account_withholding/models/account_payment.py

@@ -64,10 +64,8 @@ def action_post(self):
         for withholding in withholdings:
             liquidity_lines, counterpart_lines, writeoff_lines = withholding._seek_for_lines()
             rep_line = withholding._get_withholding_repartition_line()
-            liquidity_lines._write({
-                'tax_repartition_line_id': rep_line.id,
-                'tax_line_id': rep_line.tax_id.id,
-            })
+            liquidity_lines.tax_repartition_line_id = rep_line
+            liquidity_lines.tax_line_id = rep_line.tax_id
         return res
 
     def action_draft(self):