Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] account_payment_group_financial_surcharge: compatibility with AR EDI #349

Closed
wants to merge 2 commits into from

Conversation

zaoral
Copy link
Contributor

@zaoral zaoral commented Feb 7, 2023

Add conext key in order to be used to identify and auto complete missing fields required for EDI

…R edi

Add conext key in order to be used to identify and auto complete missing
fields required for EDI
@roboadhoc
Copy link
Contributor

If the financial plan does not add any subcharge we should not
create a ND amount 0. Only create the ND when we have a subcharge to
apply
@zaoral
Copy link
Contributor Author

zaoral commented Feb 10, 2023

@roboadhoc rebase-ff
@roboadhoc r+

@roboadhoc
Copy link
Contributor

I'm sorry, @zaoral:

  • you can't method=rebase-ff.
  • you can't review+.

@zaoral
Copy link
Contributor Author

zaoral commented Feb 10, 2023

@nicomacr Hi Nico
Please coukld you help me with this pr , the merge is telling me "you can't method=rebase-ff."

@ica-adhoc
Copy link
Contributor

@roboadhoc rebase-ff
@roboadhoc r+

@roboadhoc
Copy link
Contributor

Merge method set to rebase and fast-forward.

roboadhoc pushed a commit to ingadhoc/odoo-argentina-ee that referenced this pull request Feb 10, 2023
Be able to auto complete the missing required EDI values when the
subchange is automatically created because of the use of financial plan

closes #179

Related: ingadhoc/account-payment#349
Signed-off-by: Ignacio Cainelli <ica@adhoc.com.ar>
roboadhoc pushed a commit that referenced this pull request Feb 10, 2023
…R edi

Add conext key in order to be used to identify and auto complete missing
fields required for EDI

Part-of: #349
roboadhoc pushed a commit that referenced this pull request Feb 10, 2023
If the financial plan does not add any subcharge we should not
create a ND amount 0. Only create the ND when we have a subcharge to
apply

closes #349

Related: ingadhoc/odoo-argentina-ee#179
Signed-off-by: Ignacio Cainelli <ica@adhoc.com.ar>
@roboadhoc roboadhoc temporarily deployed to merge February 10, 2023 20:32 Inactive
@roboadhoc roboadhoc closed this Feb 10, 2023
@zaoral zaoral deleted the 13.0-h-59089-kz branch February 10, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants