[IMP] use write or direct assignation instead of update where susitable

ingadhoc · Oct 25, 2018 · 9750bf5 · 9750bf5
1 parent b39e50d
commit 9750bf5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 18 deletions.
diff --git a/account_multicompany_ux/models/product_category.py b/account_multicompany_ux/models/product_category.py
@@ -34,13 +34,9 @@ def _compute_properties(self):
             company_properties = company_property.with_context(
                 active_model=self._name,
                 active_id=rec.id)
-            values = {}
             for newfield, oldfield in property_fields.items():
-                values.update({
-                    newfield: company_properties.with_context(
-                        property_field=oldfield)._get_companies()
-                })
-            rec.update(values)
+                rec[newfield] = company_properties.with_context(
+                    property_field=oldfield)._get_companies()
 
     @api.multi
     def action_company_properties(self):

diff --git a/account_multicompany_ux/models/product_product.py b/account_multicompany_ux/models/product_product.py
@@ -32,13 +32,9 @@ def _compute_properties(self):
             company_properties = company_property.with_context(
                 active_model='product.template',
                 active_id=rec.product_tmpl_id.id)
-            values = {}
             for newfield, oldfield in property_fields.items():
-                values.update({
-                    newfield: company_properties.with_context(
-                        property_field=oldfield)._get_companies()
-                })
-            rec.update(values)
+                rec[newfield] = company_properties.with_context(
+                    property_field=oldfield)._get_companies()
 
     @api.multi
     def action_company_properties(self):

diff --git a/account_multicompany_ux/models/res_partner.py b/account_multicompany_ux/models/res_partner.py
@@ -55,13 +55,9 @@ def _compute_properties(self):
         for rec in self:
             company_properties = self.env['res.company.property'].with_context(
                 active_model=self._name, active_id=rec.id)
-            values = {}
             for newfield, oldfield in property_fields.items():
-                values.update({
-                    newfield: company_properties.with_context(
-                        property_field=oldfield)._get_companies()
-                })
-            rec.update(values)
+                rec[newfield] = company_properties.with_context(
+                    property_field=oldfield)._get_companies()
 
     @api.multi
     def action_company_properties(self):