Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13.0 imp rep cost #343

Merged
merged 9 commits into from Dec 31, 2020
Merged

13.0 imp rep cost #343

merged 9 commits into from Dec 31, 2020

Conversation

jjscarafia
Copy link
Member

No description provided.

Store price net so that recomputation of replenishment cost is faster
With this little changes we improve performance when running cron for updating list price from planned (on big database where most of the products where "by margin")
1. make auto install
2. remove unnecesary standar_price readonly (already readonly on rep cost module)
1. add dependency to stock_account to manage properly the modifications of this module, may be, on v14/v15 we can avoid this dependency because this was improved on this commit odoo/odoo@42d3a82#diff-abf4fdbe0abddfe981f6e888864caf5914302a4cc70baa2260162be1c614a01b
2. add modification of product.product views
Make new list_price and standard_price readonly because if not glue modules would be needed (for eg. for stock_account). This way we keep them only for view purposes and easy comparison with replenishment cost and planned price
The replenishment_cost_last_update is meant to represent last change on base cost, so changing the rep cost rule shouldn't update this value
@coveralls
Copy link

coveralls commented Dec 31, 2020

Coverage Status

Coverage increased (+0.8%) to 44.985% when pulling 5c73543 on adhoc-dev:13.0-imp-rep-cost into b1391fe on ingadhoc:13.0.

use new stored computed fields
@jjscarafia jjscarafia merged commit 2ae6317 into ingadhoc:13.0 Dec 31, 2020
@jjscarafia jjscarafia deleted the 13.0-imp-rep-cost branch December 31, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants