[REL] stock_inventory_require_lot to V11. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinoDefelice
commented
Jun 28, 2018
ValentinoDefelice
commented
- [FIX] Separe models and views in diferent files.
- [FIX] Update Manifest and README
nicomacr
suggested changes
Jun 28, 2018
| :target: https://runbot.adhoc.com.ar/ | ||
|
|
||
| .. repo_id is available in https://github.com/OCA/maintainer-tools/blob/master/tools/repos_with_ids.txt | ||
| .. branch is "9.0" for example | ||
|
|
There was a problem hiding this comment.
Here you need the part of the configuration, installation and usage.
| _inherit = 'stock.change.product.qty' | ||
|
|
||
| tracking = fields.Selection( | ||
| related='product_id.tracking', readonly=True |
There was a problem hiding this comment.
Valen, here it would be much better this way:
tracking = fields.Selection(
related='product_id.tracking',
readonly=True,
)
|
|
||
| _inherit = 'stock.inventory.line' | ||
|
|
||
| tracking = fields.Selection( |
There was a problem hiding this comment.
The same thing that I put in the previous comment.
* [FIX] Separe models and views in diferent files. * [FIX] Update Manifest and README
jjscarafia
force-pushed
the
11.0-t-9726-vd
branch
from
51eb7a6
to
3a17140
Compare
Codecov Report
@@ Coverage Diff @@
## 11.0 #82 +/- ##
==========================================
+ Coverage 46.19% 48.16% +1.97%
==========================================
Files 9 11 +2
Lines 210 218 +8
==========================================
+ Hits 97 105 +8
Misses 113 113
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.