Basic support for SQL connector #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awildturtok
reviewed
May 10, 2023
backend/src/main/java/com/bakdata/conquery/sql/conversion/SqlConverterService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/sql/conversion/cqelement/CQConceptConverter.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/sql/conversion/cqelement/CQConceptConverter.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/sql/conversion/cqelement/CQConceptConverter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/bakdata/conquery/sql/conversion/cqelement/CQDateRestrictionConverter.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/bakdata/conquery/integration/sql/SqlTestSpecParser.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/bakdata/conquery/integration/sql/SqlTestSpecParser.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/bakdata/conquery/integration/sql/SqlTestSpecParser.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/bakdata/conquery/integration/sql/SqlTestSpecParser.java
Outdated
Show resolved
Hide resolved
backend/src/test/resources/tests/sql/selects/date_distance/months/expected.sql
Outdated
Show resolved
Hide resolved
torbsto
force-pushed
the
sql/feature/skeleton
branch
from
82c14dc
to
6cebed0
Compare
torbsto
force-pushed
the
sql/feature/skeleton
branch
from
6cebed0
to
f3ee05d
Compare
torbsto
changed the title
|
Requires #3059 to be merged |
torbsto
force-pushed
the
sql/feature/skeleton
branch
from
93f7197
to
eba9910
Compare
This PR adds the base classes for converting ConQuery queries to SQL. A couple of notes: * We'll reevaluate the conversion mechanism and might choose to implement it directly in the respective classes * The abstraction of the SQL dialect is not part of this PR, and therefore we have a pretty tight coupling there * The `SqlTestSpecParser` is almost identical to `ConqueryTestSpec`, but I'd like to find the correct abstraction after #3059 * The integration test doesn't use the REST API yet, and therefore requires a bit more setup than the other types. Co-authored-by: Jonas Arnhold <jonars.arnhold@bakdata.com>
awildturtok
force-pushed
the
sql/feature/skeleton
branch
from
eba9910
to
b746535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the base classes for converting ConQuery queries to SQL.
A couple of notes:
SqlTestSpecParseris almost identical toConqueryTestSpec, but I'd like to find the correct abstraction after Decouple distributed execution #3059