Add HANA support (#109) #3154
Merged
Add HANA support (#109) #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Torben Meyer <torben.meyer@bakdata.com>
jnsrnhld
commented
Aug 21, 2023
There was a problem hiding this comment.
@awildturtok Alles was vorher im CQConceptConverter war, wurde jetzt in einzelne Klassen aufgeteilt. Also eine Klasse für den Preprocessing-Schritt, eine für die Filter, Selects usw. An der Funktionalität hat sich aber nichts geändert.
backend/src/test/java/com/bakdata/conquery/integration/sql/SqlIntegrationTestSpec.java
Show resolved
Hide resolved
awildturtok
approved these changes
Aug 22, 2023
.../src/main/java/com/bakdata/conquery/sql/conversion/cqelement/concept/CQConceptConverter.java
Outdated
Show resolved
Hide resolved
...nd/src/main/java/com/bakdata/conquery/sql/conversion/cqelement/concept/ConceptQueryStep.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/sql/conversion/dialect/HanaSqlFunctionProvider.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/sql/conversion/dialect/HanaSqlFunctionProvider.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/bakdata/conquery/integration/sql/CsvTableImporter.java
Show resolved
Hide resolved
backend/src/test/java/com/bakdata/conquery/integration/sql/dialect/HanaSqlIntegrationTests.java
Outdated
Show resolved
Hide resolved
...end/src/test/java/com/bakdata/conquery/integration/sql/testcontainer/hana/HanaContainer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Torben Meyer <torben.meyer@bakdata.com>
Co-authored-by: Torben Meyer <torben.meyer@bakdata.com>
…109) Co-authored-by: Torben Meyer <torben.meyer@bakdata.com>
Co-authored-by: Torben Meyer <torben.meyer@bakdata.com>
awildturtok
reviewed
Aug 23, 2023
backend/src/main/java/com/bakdata/conquery/sql/conversion/dialect/HanaSqlFunctionProvider.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Torben Meyer <torben.meyer@bakdata.com>
Co-authored-by: Torben Meyer <torben.meyer@bakdata.com>
Co-authored-by: Torben Meyer <torben.meyer@bakdata.com>
Co-authored-by: Torben Meyer <torben.meyer@bakdata.com>
awildturtok
approved these changes
Aug 23, 2023
backend/src/test/java/com/bakdata/conquery/integration/sql/dialect/HanaSqlIntegrationTests.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Torben Meyer <torben.meyer@bakdata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.