Keep row prefix constant when reordering

[fabian-bizfactory]

No description provided.

[Kadrian]

Hmm, what you'd be doing here is "hard-coding" the name row_prefix. So rowPrefixField is an optional select field with a dynamic name, and in this case it might be row_prefix, but in other fields in might be another name, so we'll have to rely on field.rowPrefixField.name for the prefix field name.

Guess what I'd try instead would be to

• pass down a rowPrefixFieldname and maybe the row itself from the FormConceptGroup to the FormConceptNode
• add both to the dragContext
• get them both from the dragContext in dropBetween
• if defined, get the prefix field value from the row + rowPrefixFieldname and pass a modified newValue to insertValue()

Does that make sense?

[fabian-bizfactory]

Hmm, what you'd be doing here is "hard-coding" the name row_prefix. So rowPrefixField is an optional select field with a dynamic name, and in this case it might be row_prefix, but in other fields in might be another name, so we'll have to rely on field.rowPrefixField.name for the prefix field name.

Guess what I'd try instead would be to

* pass down a `rowPrefixFieldname` and maybe the `row` itself from the FormConceptGroup to the FormConceptNode

* add both to the dragContext

* get them both from the dragContext in dropBetween

* if defined, get the prefix field value from the row + rowPrefixFieldname and pass a modified `newValue` to `insertValue()`

Does that make sense?

I just implemented some changes to this PR. rowPrefixFieldname is only passed. I don't think the row needs to be passed props.value[movedFromAndIdx] returns the row as well.

Please let me know what you think

[Kadrian]

Would that work with concepts dragged in from other fields as well?

[fabian-bizfactory]

No, but that wasn't possible in the previous version either. If we would allow that we would need to take in the possible values for the prefix into account, wouldn't we? To catch the case of the prefixes having different possible values.

[awildturtok]

puuh, das sieht gut so aus, aber kP ob das bei dir Nebeneffekte hat, die nicht offensichtlich sind.

zB darf newValue mutable behandelt werden?

[fabian-bizfactory]

Danke, da hast du Recht, dass prop sollte so eigentlich nicht geändert werden. Ich habe gerade eine Version gepusht die ein deep copy umsetzt (mit json)

[Kadrian]

@fabian-bizfactory I've cleaned up some of the logic, check my last commit. Was a bit easier than trying to explain. Looks good otherwise!