Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare SQL conversion of multiple connectors #3279

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Prepare SQL conversion of multiple connectors #3279

merged 9 commits into from
Jan 30, 2024

Conversation

jnsrnhld
Copy link
Collaborator

I pulled everything out of the multiple connectors PR that is only stuff like renaming, etc. which made up most of the file changes.

Some remarks on the minor bugs this PR fixes:

  • Previously, interval packing has not taken the event-filtered entities as base, but the non-filtered ones from the preprocessing step. Now, this is fixed and that's why some test cases have been adjusted which do not seem to be directly related to this PR's changes at first glance.
  • Some tests were not activated because the sqlSpec was missing in the respective JSON files.

Thus, this is more or less a No-Op PR.

@jnsrnhld jnsrnhld enabled auto-merge (squash) January 30, 2024 15:37
@jnsrnhld jnsrnhld merged commit 54537c6 into develop Jan 30, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sql/refactoring/prepare-multiple-connector-conversion branch January 30, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awildturtok awildturtok awildturtok approved these changes

Assignees
No one assigned
Labels
backend Project SQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnsrnhld @awildturtok