rip out TreeChildPrefixIndex.java and all its dependants #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoniTUB
reviewed
Feb 15, 2024
backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/tree/ConceptTreeNode.java
Show resolved
Hide resolved
| @@ -76,7 +76,7 @@ public void valid(long seed) { | |||
| IntStream | |||
| .range(0, 8192) | |||
| .boxed() | |||
| .sorted(TernaryTreeTestUtil.shuffle(random)) | |||
| .sorted(TreeTestUtil.shuffle(random)) | |||
There was a problem hiding this comment.
Kannst du hier einen kommentar ran machen, was das macht?
Es liest sich verwirrend
|
|
||
| public class TreeTestUtil { | ||
|
|
||
| public static <T> Comparator<T> shuffle(Random random) { |
There was a problem hiding this comment.
Warum braucht man hier die UUID? und den Random?
There was a problem hiding this comment.
Ich hab das nicht geschrieben, aber es assigned einfach eine random UUID jedem Element und benutzt die als comparison Wert, damit das zufällig sortiert ist. Warum das in dem TernaryTree Test so gebraúcht wird weiß ich nicht
There was a problem hiding this comment.
Okay, ich denke man könnte auch einfach random ints/Integer zurückgeben
thoniTUB
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.