Fix date restriction and validity date conversion #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awildturtok
approved these changes
Mar 5, 2024
| if (dateRestriction.hasUpperBound()) { | ||
| endDateExpression = dateRestriction.getMax().toString(); | ||
| } | ||
| public ColumnDateRange forDateRestriction(CDateRange dateRestriction) { |
There was a problem hiding this comment.
date-restrictions müssen am Ende DateSets unterstützen können. Wenn das aktuell zu kompliziert ist, ist das ok. Aber für Eva use-cases ist das notwendig.
There was a problem hiding this comment.
Das ist bekannt, würde ich aber von der Umsetzung noch hintenanstellen, da das hier nur ein Bugfix ist, der im Zusammenhang mit der Umsetzung von den event date selects aufgetreten ist.
| Column startColumn; | ||
| Column endColumn; | ||
|
|
||
| if (validityDate.getEndColumn() != null) { |
There was a problem hiding this comment.
erklärender Kommentar hier bitte
| toDateField(INFINITY_DATE_VALUE) | ||
| ); | ||
|
|
||
| dateRange = daterange(startColumn, endColumn, "[]"); |
There was a problem hiding this comment.
bitte direkt returnen, ich will nicht so viel scrollen müssen für ein return dateRange.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs fixed:
ColumnDateRangewith an exclusive endColumnDateRangeand there was a date restriction, theColumnDateRangecontained the full range of the respective validity date and was not limited by the given date restriction