Role matching OIDC #3335
Merged
Role matching OIDC #3335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awildturtok
force-pushed
the
feature/role-matching-oidc
branch
from
f7970e6
to
7bd8ef8
Compare
thoniTUB
requested changes
Mar 6, 2024
backend/src/main/java/com/bakdata/conquery/apiv1/auth/ProtoRole.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/auth/AuthorizationController.java
Outdated
Show resolved
Hide resolved
Comment on lines
163
to
171
| if (user.getRoles().contains(roleId)) { | ||
| continue; | ||
| } | ||
|
|
||
| final Role role = storage.getRole(roleId); | ||
|
|
||
| if (role == null) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
In die IFs bitte auch traces
Comment on lines
17
to
18
| @Valid | ||
| private List<ProtoRole> initialRoles; |
There was a problem hiding this comment.
Hier noch die default admin rolle definieren
| return new ConqueryAuthenticationInfo(user, token, this, true); | ||
| } | ||
| } | ||
|
|
||
| throw new UnknownAccountException("The user id was unknown: " + subject); | ||
| } | ||
|
|
||
| private void handleRoleClaims(AccessToken accessToken, User user) { |
There was a problem hiding this comment.
Wir sollten ggf. noch das Token/ oder die Tokensignature hashen, damit wir das nicht bei jedem request ausführen
thoniTUB
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.