Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move frontend Dockerfile to root; add git describe #3349

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Move frontend Dockerfile to root; add git describe #3349

merged 6 commits into from
Mar 19, 2024

Conversation

Kadrian
Copy link
Collaborator

@Kadrian Kadrian commented Mar 18, 2024

No description provided.

@thoniTUB
Copy link
Collaborator

Looks goot to me.
I tried to identify other files that need to be updated, but all deployments work on the produced images from the github workflow and don't build the image themselves.

@awildturtok do you see any problems regarding eva?

awildturtok
awildturtok approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@awildturtok awildturtok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thoniTUB wüsste nicht was, sieht überschaubaur aus.

@thoniTUB thoniTUB merged commit 3b964a9 into develop Mar 19, 2024
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the improve-version-handling branch March 19, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awildturtok awildturtok awildturtok approved these changes

@thoniTUB thoniTUB thoniTUB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kadrian @thoniTUB @awildturtok