-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache position at startup #3395
Conversation
public void init() { | ||
position = ArrayUtils.indexOf(getTable().getColumns(), this); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich denke, dass es hier sauberer ist, wenn wir den Setter setTable()
überschreiben. Den sollte Jackson dann auch nutzen können.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oha nice! Gute idee!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hab es gerade ausprobiert, das geht nicht, weil columns erst initialisiert wird nach der column construction :<
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
War die lazy init denn der Grund für die vielen Lambdas im histo, oder wie kommt es zu dem PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nein, aber wir haben beide schon unabhängig in flamegraphs von calculateCblocks sehr viel getColumn calls gesehen, die ja eigentlich komplett überflüssig sind wenn die methode ordentlich inlined wird (was sie anscheinend nicht wird). Weil sie ja komplett statisch sein kann wie hier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oki
No description provided.