Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iteration over concept trees when setting default filter values #62

Merged
merged 2 commits into from
Feb 16, 2018
Merged

Fix iteration over concept trees when setting default filter values #62

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f07eebb
Fix iteration over concept trees when setting default filter values
Feb 16, 2018
f2495a9
Use const instead of let
Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 5 additions & 6 deletions frontend/lib/js/category-trees/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,11 @@ export const loadTrees = (datasetId: DatasetIdType) => {
dispatch(loadTreesSuccess(r));

// Assign default select filter values
Object.values(r.concepts).forEach(concept => concept.tables.forEach(table =>
table.filters.forEach(filter => {
if (filter.defaultValue)
filter.value = filter.defaultValue;
})
));
for (const concept of Object.values(r.concepts))
for (const table of concept.tables || [])
for (const filter of table.filters || [])
if (filter.defaultValue)
filter.value = filter.defaultValue;

// In the future: Data could be cached, version could be checked and
// further data only loaded when necessary
Expand Down