Upgrade Blitz.js and Prisma #25
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Blitz.js 0.27.1 -> 0.29.7 - Prisma ~2.12 -> 2.15.0 - Updated `prisma migrate` - Modified `prisma-test-environment` to match new breaking changes - Fix some broken pieces of code after upgrade
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ingenious-agency/mensaje/5sft4792b |
cherta
reviewed
Jan 29, 2021
| @@ -17,8 +17,11 @@ async function createReaction({ data }: CreateReactionInput, ctx: Ctx) { | |||
| }) | |||
| if (existingReaction) return existingReaction | |||
|
|
|||
| // Add the user connection to data | |||
| data.user = { connect: { id: ctx.session.userId } } | |||
There was a problem hiding this comment.
Why this instead of spreading? Just curious...
There was a problem hiding this comment.
I don't know exactly why, but when the spreading is used, the ide throws a types error. I suspect that something new about blitz + spreading data onto a non typed object makes typescript confused, but I got surprised of this too.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prisma migrateprisma-test-environmentto match new breaking changesWARNING: This PR may break the Production database if merged and deployed.
In order to avoid this, we must baseline our Production environment. This isn't done yet, I'll update when this is finished.
TO DOs