Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separable compilation for Rust #244

Merged
merged 36 commits into from
Nov 16, 2023
Merged

separable compilation for Rust #244

merged 36 commits into from
Nov 16, 2023

Conversation

vhnatyk
Copy link
Contributor

@vhnatyk vhnatyk commented Oct 11, 2023

Describe the changes

enables separable compilation for Rust via cmake

TODO: goicicle? I doesn't affect go now, but we should switch to cmake asap

Linked Issues

Resolves #
#63

@vhnatyk vhnatyk linked an issue Oct 11, 2023 that may be closed by this pull request
@ImmanuelSegol ImmanuelSegol marked this pull request as ready for review October 12, 2023 12:32
Copy link
Collaborator

@jeremyfelder jeremyfelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format cuda files
Otherwise looks good 👍🏻

ImmanuelSegol
ImmanuelSegol previously approved these changes Oct 15, 2023
Copy link
Contributor

@ImmanuelSegol ImmanuelSegol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. looks good.
  2. there is a conflict in msm.cu
  3. lint plz :)

icicle/CMakeLists.txt Show resolved Hide resolved
ImmanuelSegol
ImmanuelSegol previously approved these changes Oct 17, 2023
build.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jeremyfelder jeremyfelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions. Looks great 💪🏻

build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
@vhnatyk vhnatyk self-assigned this Nov 15, 2023
Vitalii and others added 4 commits November 15, 2023 09:27
This reverts commit f456978.
pr comment

Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
DmytroTym
DmytroTym previously approved these changes Nov 15, 2023
Copy link
Contributor

@DmytroTym DmytroTym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vhnatyk vhnatyk merged commit 7baea7c into main Nov 16, 2023
10 of 11 checks passed
@vhnatyk vhnatyk deleted the feat/vhnat/63-compilation-time branch November 16, 2023 07:44
@vhnatyk vhnatyk mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation time
4 participants