-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
separable compilation for Rust #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format cuda files
Otherwise looks good 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- looks good.
- there is a conflict in msm.cu
- lint plz :)
…at/63-compilation-time
…at/63-compilation-time
f2e2d94
to
af87bec
Compare
…at/63-compilation-time
This reverts commit 4c42d13.
…at/63-compilation-time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestions. Looks great 💪🏻
This reverts commit f456978.
pr comment Co-authored-by: Jeremy Felder <jeremy.felder1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Describe the changes
enables separable compilation for Rust via cmake
TODO: goicicle? I doesn't affect go now, but we should switch to cmake asap
Linked Issues
Resolves #
#63