Two curve NTT correctness issue hotfix #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImmanuelSegol
previously approved these changes
Oct 29, 2023
jeremyfelder
previously approved these changes
Oct 30, 2023
jeremyfelder
dismissed stale reviews from ImmanuelSegol and themself
via
f909f8e
jeremyfelder
force-pushed
the
fix/dima/two-curve-ntt-correctness-issue
branch
from
08b05e5
to
bea3c24
Compare
|
@ImmanuelSegol yea I thought about commenting it somewhere but not sure where tbh. And I'm still not 100% sure when this happens too... |
ImmanuelSegol
approved these changes
Nov 3, 2023
jeremyfelder
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the problem occurring in gnark groth16 circuits that use more than one curve simultaneously. More specifically, verification fails due to
krs2MSM being incorrect, in turn caused bycomputeHfunction returning incorrect result. On closer inspection it turned out thattemplate_normalize_kernelhere just doesn't launch. It does so silently, without throwing any errors or visible memory leaks. It does seem that the problem has to do with compilation because simply using the same kernel with a different name helps as well as only using a single curve. The "fix" in this PR just replaces a second use-case oftemplate_normalize_kernelwith a more correct Montgomery treatment cherry-picked from our new API branch. I will try to get more info about this error in the following days while for now this fix should suffice.PS: guess it's one more point for unified compilation for different wrapper languages - hopefully we'll have fewer strange hard-to-debug C++ compilation bugs that way lol...