Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixed radix NTT coset support #368

Merged
merged 1 commit into from Feb 12, 2024
Merged

Mixed radix NTT coset support #368

merged 1 commit into from Feb 12, 2024

Conversation

yshekel
Copy link
Collaborator

@yshekel yshekel commented Feb 8, 2024

No description provided.

@yshekel yshekel force-pushed the yshekel/mixed_radix_ntt_coset branch 3 times, most recently from f68c91a to e4d48b2 Compare February 11, 2024 09:25
@yshekel yshekel force-pushed the yshekel/mixed_radix_ntt_coset branch from e4d48b2 to 1292856 Compare February 11, 2024 12:26
@yshekel yshekel marked this pull request as ready for review February 11, 2024 12:33
@yshekel yshekel force-pushed the yshekel/mixed_radix_ntt_coset branch from 1292856 to 5d5aa8f Compare February 12, 2024 11:32
@yshekel yshekel force-pushed the yshekel/mixed_radix_ntt_coset branch from 5d5aa8f to 3753937 Compare February 12, 2024 12:52
DmytroTym
DmytroTym approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@DmytroTym DmytroTym left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coset tests in Rust currently don't check new version but once ordering PR is merged they will (as far as I understood) so all is good imo

@yshekel yshekel merged commit ae06031 into dev Feb 12, 2024
14 checks passed
@yshekel yshekel deleted the yshekel/mixed_radix_ntt_coset branch February 12, 2024 16:30
@DmytroTym DmytroTym mentioned this pull request Feb 15, 2024
Merged
DmytroTym added a commit that referenced this pull request Feb 15, 2024
@DmytroTym
Release v1.4.0 (#378)
15a63cc 
## Contents of this release

[FEAT]: support for multi-device execution:
#356
[FEAT]: full support for new mixed-radix NTT:
#367,
#368 and
#371
[FEAT]: examples for Poseidon hash and tree builder based on it
(currently only on C++ side):
#375
[PERF]: MSM performance upgrades & zero point handling:
#372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroTym DmytroTym DmytroTym approved these changes

@HadarIngonyama HadarIngonyama Awaiting requested review from HadarIngonyama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yshekel @DmytroTym