Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix for large ecntt #448

Merged
merged 3 commits into from
Mar 27, 2024
Merged

hotfix for large ecntt #448

merged 3 commits into from
Mar 27, 2024

Conversation

vhnatyk
Copy link
Contributor

@vhnatyk vhnatyk commented Mar 27, 2024 •
edited

Describe the changes

  • This PR is a hotfix for large ECNTTs of size 2^18 x 64 and above
  • Rust bindings benchmarks and correctness test against Arkworks to come in subsequent PRs

Linked Issues

Resolves #

yshekel
yshekel reviewed Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@yshekel yshekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think it's worth adding a test for the problematic case and make sure it is solved.

@vhnatyk
Copy link
Contributor Author

vhnatyk commented Mar 27, 2024

the comment by @yshekel will be resolved as discussed

@vhnatyk vhnatyk merged commit ef757e8 into main Mar 27, 2024
21 checks passed
@vhnatyk vhnatyk deleted the fix/large-ecntt branch March 27, 2024 17:31
ChickenLover pushed a commit that referenced this pull request Apr 2, 2024
@vhnatyk @ChickenLover
hotfix for large ecntt (#448)
96b84c2 
 hotfix for large ECNTTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshekel yshekel yshekel left review comments

@DmytroTym DmytroTym DmytroTym approved these changes

@LeonHibnik LeonHibnik LeonHibnik approved these changes

@jeremyfelder jeremyfelder Awaiting requested review from jeremyfelder

@ChickenLover ChickenLover Awaiting requested review from ChickenLover

@nonam3e nonam3e Awaiting requested review from nonam3e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vhnatyk @DmytroTym @yshekel @LeonHibnik