NTT inplace in Rust #453
Merged
NTT inplace in Rust #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChickenLover
approved these changes
Apr 4, 2024
yshekel
approved these changes
Apr 4, 2024
yshekel
force-pushed
the
dima/ntt_inplace
branch
from
6be03c3
to
9a42ff3
Compare
yshekel
pushed a commit
that referenced
this pull request
May 19, 2024
## Describe the changes Due to Rust's ownership rules, we can't run NTT inplace using the [`ntt`](https://github.com/ingonyama-zk/icicle/blob/v1.9.1/wrappers/rust/icicle-core/src/ntt/mod.rs#L139) function. Which is why we saw a need to add a separate function a couple of times. Incidentally an issue with radix-2 NTT was found when ran inplace, `__syncthreads()` was used in reverse order kernel as if it was a global barrier for all blocks and not block-local one. Thus data race happened that is fixed by this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Due to Rust's ownership rules, we can't run NTT inplace using the
nttfunction. Which is why we saw a need to add a separate function a couple of times.Incidentally an issue with radix-2 NTT was found when ran inplace,
__syncthreads()was used in reverse order kernel as if it was a global barrier for all blocks and not block-local one. Thus data race happened that is fixed by this PR.