fix: use the log2 in lib std explicitly to prevent makefile from link… #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing other log2 func
|
Thank you @JimmyHongjichuan ! 🙏🏻 |
LeonHibnik
approved these changes
Apr 6, 2024
|
Hi, can someone merge this PR? So we can update our depends to fix the bug. |
|
@JimmyHongjichuan Thank you! merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing other log2 func
Describe the changes
This PR adds "std" as prefix on log2 function of icicle/appUtils/msm/msm.cu to explicitly use std::log2 for MSM calculatation.
Linked Issues
#458
Resolves #